Bug 128490

Summary: [iOS][wk2] ASSERT(WebThreadIsCurrent()) in [WebDisplayLinkHandler handleDisplayLink:]
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebCore Misc.Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, dino, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Tim Horton
Reported 2014-02-08 23:19:14 PST
[WebDisplayLinkHandler handleDisplayLink:] has an ASSERT(WebThreadIsCurrent()). We don't use the Web Thread in WebKit2, but it looks to me like isMainThread() does the right thing (main thread if web thread is disabled, web thread otherwise), so let's use that.
Attachments
patch (1.47 KB, patch)
2014-02-08 23:21 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-02-08 23:21:47 PST
Created attachment 223613 [details] patch Hopefully someone can clarify if isMainThead does the right thing. And maybe we should audit other callers of WebThreadIsCurrent?
WebKit Commit Bot
Comment 2 2014-02-09 16:21:34 PST
Comment on attachment 223613 [details] patch Clearing flags on attachment: 223613 Committed r163758: <http://trac.webkit.org/changeset/163758>
WebKit Commit Bot
Comment 3 2014-02-09 16:21:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.