Bug 128484

Summary: Add the basic infrastructure to compile attributes matching in selectors
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, cmarcelo, commit-queue, d-r, esprehn+autocc, fmalita, ggaren, gyuyoung.kim, kangil.han, pdr, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch barraclough: review+

Benjamin Poulain
Reported 2014-02-08 20:31:30 PST
Add the basic infrastructure to compile attributes matching in selectors
Attachments
Patch (57.27 KB, patch)
2014-02-08 20:45 PST, Benjamin Poulain 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-02-08 20:45:35 PST
Created attachment 223604 [details] Patch
Gavin Barraclough
Comment 2 2014-02-10 17:28:24 PST
Comment on attachment 223604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223604&action=review > Source/WebCore/cssjit/SelectorCompiler.cpp:414 > } It looks like the code above here could be simpler if you fully handled the success case above the failure cases? – it would duplicate the restore, but that's a couple of extra loads & it would save a jump. > Source/WebCore/cssjit/SelectorCompiler.cpp:992 > + // In general, canonicalLocalName and localName are the same. When they differe, we have to check if the node is HTML to know differe > Source/WebCore/dom/Attribute.h:86 > + return Attribute::nameMatchesFilter(m_name, prefix, localName, namespaceURI); I don't think you need "Attribute::"?
Benjamin Poulain
Comment 3 2014-02-10 18:36:08 PST
Committed r163850: <http://trac.webkit.org/changeset/163850>
Note You need to log in before you can comment on or make changes to this bug.