| Summary: | Add the basic infrastructure to compile attributes matching in selectors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, cmarcelo, commit-queue, d-r, esprehn+autocc, fmalita, ggaren, gyuyoung.kim, kangil.han, pdr, schenney, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-02-08 20:31:30 PST
Created attachment 223604 [details]
Patch
Comment on attachment 223604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223604&action=review > Source/WebCore/cssjit/SelectorCompiler.cpp:414 > } It looks like the code above here could be simpler if you fully handled the success case above the failure cases? – it would duplicate the restore, but that's a couple of extra loads & it would save a jump. > Source/WebCore/cssjit/SelectorCompiler.cpp:992 > + // In general, canonicalLocalName and localName are the same. When they differe, we have to check if the node is HTML to know differe > Source/WebCore/dom/Attribute.h:86 > + return Attribute::nameMatchesFilter(m_name, prefix, localName, namespaceURI); I don't think you need "Attribute::"? Committed r163850: <http://trac.webkit.org/changeset/163850> |