Bug 128483

Summary: Simplify single character substrings in JSC
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: REOPENED    
Severity: Normal CC: commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 128491    
Bug Blocks:    
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2014-02-08 19:39:49 PST
Simplify single character substrings in JSC
Attachments
Patch (4.55 KB, patch)
2014-02-08 19:41 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-02-08 19:41:40 PST
Created attachment 223601 [details] Patch
Andreas Kling
Comment 2 2014-02-08 19:43:21 PST
Comment on attachment 223601 [details] Patch Nice ;D
Anders Carlsson
Comment 3 2014-02-08 19:47:01 PST
Committed r163737: <http://trac.webkit.org/changeset/163737>
Ryosuke Niwa
Comment 4 2014-02-08 23:59:04 PST
Looks like this patch broke 10 tests: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/3233
Ryosuke Niwa
Comment 5 2014-02-09 00:01:48 PST
e.g. --- /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/fast/lists/w3-css3-list-styles-alphabetic-expected.txt +++ /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/fast/lists/w3-css3-list-styles-alphabetic-actual.txt @@ -11,82 +11,82 @@ PASS list marker is በ. PASS list marker is ተ. PASS list marker is ነ. -PASS list marker is አ. -PASS list marker is ከ. -PASS list marker is ወ. -PASS list marker is ዐ. -PASS list marker is የ. +FAIL list marker should be በ. Was አ. +FAIL list marker should be ሰ. Was ከ. +FAIL list marker should be ሐ. Was ወ. +FAIL list marker should be ለ. Was ዐ. +FAIL list marker should be ሀ. Was የ. PASS list marker is ደ. PASS list marker is ገ. PASS list marker is ጸ. PASS list marker is ፈ. ethiopic-halehame-aa-et
WebKit Commit Bot
Comment 6 2014-02-09 00:12:00 PST
Re-opened since this is blocked by bug 128491
Ryosuke Niwa
Comment 7 2014-02-09 00:13:16 PST
I'm going to rollout the patch for now since neither kling nor I can spot the error and this is going to hose EWS if we kept it in trunk.
Note You need to log in before you can comment on or make changes to this bug.