| Summary: | Simplify single character substrings in JSC | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | commit-queue, rniwa | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 128491 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2014-02-08 19:39:49 PST
Created attachment 223601 [details]
Patch
Comment on attachment 223601 [details]
Patch
Nice ;D
Committed r163737: <http://trac.webkit.org/changeset/163737> Looks like this patch broke 10 tests: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/3233 e.g. --- /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/fast/lists/w3-css3-list-styles-alphabetic-expected.txt +++ /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/fast/lists/w3-css3-list-styles-alphabetic-actual.txt @@ -11,82 +11,82 @@ PASS list marker is በ. PASS list marker is ተ. PASS list marker is ነ. -PASS list marker is አ. -PASS list marker is ከ. -PASS list marker is ወ. -PASS list marker is ዐ. -PASS list marker is የ. +FAIL list marker should be በ. Was አ. +FAIL list marker should be ሰ. Was ከ. +FAIL list marker should be ሐ. Was ወ. +FAIL list marker should be ለ. Was ዐ. +FAIL list marker should be ሀ. Was የ. PASS list marker is ደ. PASS list marker is ገ. PASS list marker is ጸ. PASS list marker is ፈ. ethiopic-halehame-aa-et Re-opened since this is blocked by bug 128491 I'm going to rollout the patch for now since neither kling nor I can spot the error and this is going to hose EWS if we kept it in trunk. |