Bug 128464

Summary: Stop using PLATFORM(MAC) in WebCore except where it means “OS X but not iOS”
Product: WebKit Reporter: mitz
Component: WebCore Misc.Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, annulen, darin, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Replace PLATFORM(MAC) with equivalent alternatives andersca: review+

mitz
Reported 2014-02-08 11:57:25 PST
So that we can make PLATFORM(MAC) false when building for iOS, we need to replace all uses of it that don’t take iOS into account. Most such uses are about building for Cocoa.
Attachments
Replace PLATFORM(MAC) with equivalent alternatives (75.42 KB, patch)
2014-02-08 12:46 PST, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-02-08 12:46:40 PST
Created attachment 223577 [details] Replace PLATFORM(MAC) with equivalent alternatives
mitz
Comment 2 2014-02-08 14:21:57 PST
Committed <http://trac.webkit.org/r163725>.
Joseph Pecoraro
Comment 3 2014-02-08 14:38:07 PST
Nice!
Konstantin Tokarev
Comment 4 2016-02-19 11:42:52 PST
What was the motivation to use OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK) in XSLT code instead of simple PLATFORM(COCOA)?
Note You need to log in before you can comment on or make changes to this bug.