Bug 128457

Summary: Stop using getCharactersWithUpconvert in JavaScriptCore
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Anders Carlsson 2014-02-08 10:17:49 PST 
Stop using getCharactersWithUpconvert in JavaScriptCore
Comment 1 Anders Carlsson 2014-02-08 10:19:47 PST 
Created attachment 223570 [details]
Patch
Comment 2 Andreas Kling 2014-02-08 12:43:21 PST 
Comment on attachment 223570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223570&action=review

Nice! r=me

> Source/WTF/wtf/text/StringView.h:141
> +        if (is8Bit())
> +            return WTF::find(characters8(), length(), character, start);

I wonder if it would be useful to have an early return here if 'character' is outside the LChar range. NABD.
Comment 3 Geoffrey Garen 2014-02-08 13:11:51 PST 
Comment on attachment 223570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223570&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        if the source or replacement strings area 16-bit.

"are"
Comment 4 WebKit Commit Bot 2014-02-08 15:26:39 PST 
Comment on attachment 223570 [details]
Patch

Clearing flags on attachment: 223570

Committed r163727: <http://trac.webkit.org/changeset/163727>
Comment 5 WebKit Commit Bot 2014-02-08 15:26:41 PST 
All reviewed patches have been landed.  Closing bug.