Bug 128449

Summary:

[GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage

Product:

WebKit

Reporter:

Piotr Grad <piotr.grad>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, cgarcia, commit-queue, gustavo, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	cgarcia: review-
Patch	cgarcia: review+, commit-queue: commit-queue-
Patch	none

Piotr Grad

Reported 2014-02-07 23:50:25 PST

context->createWebPage is called with inproper parameter

Attachments
Patch (1.56 KB, patch) 2014-02-07 23:52 PST, Piotr Grad	no flags	Details Formatted Diff Diff
Patch (1.56 KB, patch) 2014-02-07 23:54 PST, Piotr Grad	cgarcia: review-	Details Formatted Diff Diff
Patch (1.48 KB, patch) 2014-02-08 00:25 PST, Piotr Grad	cgarcia: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch (1.48 KB, patch) 2014-02-08 00:44 PST, Piotr Grad	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Piotr Grad

Comment 1 2014-02-07 23:52:31 PST

Created attachment 223556 [details] Patch

WebKit Commit Bot

Comment 2 2014-02-07 23:54:18 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Piotr Grad

Comment 3 2014-02-07 23:54:52 PST

Created attachment 223557 [details] Patch

Carlos Garcia Campos

Comment 4 2014-02-07 23:58:50 PST

Comment on attachment 223557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223557&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:957 > + webPageConfiguration.relatedPage = webkitWebViewBaseGetPage(webkitWebViewBase); This is not correct, you are using the page you are creating as the related page. You should not initialize the related page (it's already null at this point), is currently unimplemented in gtk+ port.

Piotr Grad

Comment 5 2014-02-08 00:25:57 PST

Created attachment 223559 [details] Patch

Carlos Garcia Campos

Comment 6 2014-02-08 00:28:27 PST

Comment on attachment 223559 [details] Patch Thank you!

WebKit Commit Bot

Comment 7 2014-02-08 00:31:11 PST

Comment on attachment 223559 [details] Patch Rejecting attachment 223559 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 223559, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit2/ChangeLog is not at the top of the file. Full output: http://webkit-queues.appspot.com/results/6059916125011968

Carlos Garcia Campos

Comment 8 2014-02-08 00:34:23 PST

Comment on attachment 223559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223559&action=review > Source/WebKit2/ChangeLog:3 > 2014-02-07 Piotr Grad <p.grad@samsung.com> > > +2014-02-07 Piotr Grad <p.grad@samsung.com> Right, this is wrong > Source/WebKit2/ChangeLog:15 > + > [GTK] Build break in WebKitSettings The date and author should be here. Please fix the changelog :-)

Piotr Grad

Comment 9 2014-02-08 00:44:51 PST

Created attachment 223561 [details] Patch

WebKit Commit Bot

Comment 10 2014-02-08 01:21:49 PST

Comment on attachment 223561 [details] Patch Clearing flags on attachment: 223561 Committed r163708: <http://trac.webkit.org/changeset/163708>

WebKit Commit Bot

Comment 11 2014-02-08 01:21:51 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.