Bug 128441

Summary:

Split UserTriggered into FireSelectEvent and RevealSelection for selection options

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, commit-queue, darin, enrica, kling, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

127832

Attachments:

Description	Flags
Cleanup	none

Description Ryosuke Niwa 2014-02-07 22:13:13 PST

Right now a lot of functions call setSelection with UserTriggered and DoNotRevealSelection
in order to let select event fire without revealing selection.

We should split UserTriggered into FireSelectEvent and RevealSelection instead.

Comment 1 Ryosuke Niwa 2014-02-07 22:20:56 PST

Created attachment 223550 [details]
Cleanup

Comment 2 WebKit Commit Bot 2014-02-08 13:35:35 PST

Comment on attachment 223550 [details]
Cleanup

Clearing flags on attachment: 223550

Committed r163721: <http://trac.webkit.org/changeset/163721>

Comment 3 WebKit Commit Bot 2014-02-08 13:35:37 PST

All reviewed patches have been landed.  Closing bug.