Bug 128441

Summary: Split UserTriggered into FireSelectEvent and RevealSelection for selection options
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, darin, enrica, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127832    
Attachments:
Description Flags
Cleanup none

Ryosuke Niwa
Reported 2014-02-07 22:13:13 PST
Right now a lot of functions call setSelection with UserTriggered and DoNotRevealSelection in order to let select event fire without revealing selection. We should split UserTriggered into FireSelectEvent and RevealSelection instead.
Attachments
Cleanup (18.11 KB, patch)
2014-02-07 22:20 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-02-07 22:20:56 PST
Created attachment 223550 [details] Cleanup
WebKit Commit Bot
Comment 2 2014-02-08 13:35:35 PST
Comment on attachment 223550 [details] Cleanup Clearing flags on attachment: 223550 Committed r163721: <http://trac.webkit.org/changeset/163721>
WebKit Commit Bot
Comment 3 2014-02-08 13:35:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.