Bug 128439

Summary:

Merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, darin, enrica, kling, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

127832

Attachments:

Description	Flags
Cleanup	andersca: review+

Description Ryosuke Niwa 2014-02-07 20:53:02 PST

FrameSelection::selectAll() has superfluous call to updateSelectionCachesIfSelectionIsInsideTextFormControl and selectFrameElementInParentIfFullySelected
because it doesn't call setSelection with UserTriggered set.

Do that and merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance

Comment 1 Ryosuke Niwa 2014-02-07 20:59:52 PST

Created attachment 223544 [details]
Cleanup

Comment 2 Ryosuke Niwa 2014-02-07 21:22:18 PST

Committed r163692: <http://trac.webkit.org/changeset/163692>