Bug 128439

Summary: Merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, darin, enrica, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127832    
Attachments:
Description Flags
Cleanup andersca: review+

Ryosuke Niwa
Reported 2014-02-07 20:53:02 PST
FrameSelection::selectAll() has superfluous call to updateSelectionCachesIfSelectionIsInsideTextFormControl and selectFrameElementInParentIfFullySelected because it doesn't call setSelection with UserTriggered set. Do that and merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance
Attachments
Cleanup (7.37 KB, patch)
2014-02-07 20:59 PST, Ryosuke Niwa 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-02-07 20:59:52 PST
Created attachment 223544 [details] Cleanup
Ryosuke Niwa
Comment 2 2014-02-07 21:22:18 PST
Committed r163692: <http://trac.webkit.org/changeset/163692>
Note You need to log in before you can comment on or make changes to this bug.