Bug 128428

Summary:

Remove isInitialState flag from Page::setViewState

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebCore Misc.

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, gyuyoung.kim, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	sam: review+

Description Gavin Barraclough 2014-02-07 17:57:09 PST

This is used for two purposes; one is unnecessary, the other is a bug.

Comment 1 Gavin Barraclough 2014-02-07 18:02:37 PST

Created attachment 223532 [details]
Fix

Comment 2 WebKit Commit Bot 2014-02-07 18:04:57 PST

Attachment 223532 [details] did not pass style-queue:


ERROR: Source/WebCore/page/Page.h:294:  The parameter name "isVisible" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/page/Page.h:422:  The parameter name "isVisible" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 4 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Gavin Barraclough 2014-02-07 18:20:22 PST

Transmitting file data ................
Committed revision 163679.