Bug 128418

Summary: [GTK] generate-gtkdoc should use argparse
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dbates, rego
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128417    
Attachments:
Description Flags
Patch cgarcia: review+

Martin Robinson
Reported 2014-02-07 16:59:56 PST
It's 2014.
Attachments
Patch (14.84 KB, patch)
2014-02-17 19:05 PST, Martin Robinson
cgarcia: review+
Martin Robinson
Comment 1 2014-02-17 19:05:46 PST
Martin Robinson
Comment 2 2014-02-17 19:06:29 PST
This patch also disposes of the common options method. The option methods will disappear completely in 128417.
Carlos Garcia Campos
Comment 3 2014-02-18 00:16:32 PST
Comment on attachment 224457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224457&action=review > Tools/gtk/generate-gtkdoc:170 > - options = get_common_options().copy() > - options.update({ > + options = { > + 'decorator': 'WEBKIT_API|WEBKIT_DEPRECATED|WEBKIT_DEPRECATED_FOR\(.+\)', > + 'deprecation_guard': 'WEBKIT_DISABLE_DEPRECATED', > + 'library_path' : common.library_build_path(), > + 'virtual_root' : virtual_root, Why are we now duplicating this code in every get_*_options method?
Martin Robinson
Comment 4 2014-02-18 07:31:51 PST
(In reply to comment #3) > (From update of attachment 224457 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=224457&action=review > > > Tools/gtk/generate-gtkdoc:170 > > - options = get_common_options().copy() > > - options.update({ > > + options = { > > + 'decorator': 'WEBKIT_API|WEBKIT_DEPRECATED|WEBKIT_DEPRECATED_FOR\(.+\)', > > + 'deprecation_guard': 'WEBKIT_DISABLE_DEPRECATED', > > + 'library_path' : common.library_build_path(), > > + 'virtual_root' : virtual_root, > > Why are we now duplicating this code in every get_*_options method? It's a bit awkward like this, but it makes sense because in the next patch in the series these are no longer duplicated.
Martin Robinson
Comment 5 2014-02-23 13:35:46 PST
Note You need to log in before you can comment on or make changes to this bug.