Bug 128411

Summary:

Implement more of WKPreferences

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Anders Carlsson 2014-02-07 16:25:21 PST

Implement more of WKPreferences

Comment 1 Anders Carlsson 2014-02-07 16:26:45 PST

Created attachment 223513 [details]
Patch

Comment 2 WebKit Commit Bot 2014-02-07 16:29:04 PST

Attachment 223513 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesInternal.h:36:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Tim Horton 2014-02-07 16:30:43 PST

Comment on attachment 223513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223513&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:40
> +    _preferences = WebKit::WebPreferences::create(String());

using namespace WebKit?

Comment 4 Anders Carlsson 2014-02-07 16:32:34 PST

Committed r163663: <http://trac.webkit.org/changeset/163663>