Bug 128411 - Implement more of WKPreferences
Summary: Implement more of WKPreferences
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2014-02-07 16:25 PST by Anders Carlsson
Modified: 2014-02-07 16:32 PST (History)
1 user (show)

See Also:

Patch (9.87 KB, patch)
2014-02-07 16:26 PST, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-07 16:25:21 PST
Implement more of WKPreferences
Comment 1 Anders Carlsson 2014-02-07 16:26:45 PST
Created attachment 223513 [details]
Comment 2 WebKit Commit Bot 2014-02-07 16:29:04 PST
Attachment 223513 [details] did not pass style-queue:

ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesInternal.h:36:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-02-07 16:30:43 PST
Comment on attachment 223513 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=223513&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:40
> +    _preferences = WebKit::WebPreferences::create(String());

using namespace WebKit?
Comment 4 Anders Carlsson 2014-02-07 16:32:34 PST
Committed r163663: <http://trac.webkit.org/changeset/163663>