WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128411
Implement more of WKPreferences
https://bugs.webkit.org/show_bug.cgi?id=128411
Summary
Implement more of WKPreferences
Anders Carlsson
Reported
2014-02-07 16:25:21 PST
Implement more of WKPreferences
Attachments
Patch
(9.87 KB, patch)
2014-02-07 16:26 PST
,
Anders Carlsson
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-02-07 16:26:45 PST
Created
attachment 223513
[details]
Patch
WebKit Commit Bot
Comment 2
2014-02-07 16:29:04 PST
Attachment 223513
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesInternal.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3
2014-02-07 16:30:43 PST
Comment on
attachment 223513
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=223513&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:40 > + _preferences = WebKit::WebPreferences::create(String());
using namespace WebKit?
Anders Carlsson
Comment 4
2014-02-07 16:32:34 PST
Committed
r163663
: <
http://trac.webkit.org/changeset/163663
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug