Bug 128407

Summary: Remove some unused functions from SerializedScriptValue
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, andersca, commit-queue, jsbell, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
part 2
none
part 3 oliver: review+

Description Alexey Proskuryakov 2014-02-07 15:28:55 PST 
SerializedScriptValue has accumulated a lot of cruft. I'll remove it in small steps, as maybe some ports still use some of that.
Comment 1 Alexey Proskuryakov 2014-02-07 15:30:07 PST 
Created attachment 223504 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-02-07 17:05:04 PST 
Comment on attachment 223504 [details]
proposed patch

Clearing flags on attachment: 223504

Committed r163667: <http://trac.webkit.org/changeset/163667>
Comment 3 WebKit Commit Bot 2014-02-07 17:05:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2014-02-08 15:23:28 PST 
Re-opening for more.
Comment 5 Alexey Proskuryakov 2014-02-08 15:29:32 PST 
Created attachment 223589 [details]
part 2
Comment 6 WebKit Commit Bot 2014-02-08 17:16:36 PST 
Comment on attachment 223589 [details]
part 2

Clearing flags on attachment: 223589

Committed r163732: <http://trac.webkit.org/changeset/163732>
Comment 7 WebKit Commit Bot 2014-02-08 17:16:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2014-02-10 13:16:21 PST 
And yet more.
Comment 9 Alexey Proskuryakov 2014-02-10 13:18:31 PST 
Created attachment 223737 [details]
part 3
Comment 10 WebKit Commit Bot 2014-02-10 13:21:33 PST 
Attachment 223737 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/IDBBindingUtilities.cpp:335:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:146:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:147:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:148:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Alexey Proskuryakov 2014-02-10 13:32:10 PST 
Committed <http://trac.webkit.org/r163810>.