Bug 128406

Summary: Fix bug in stack limit adjustments in JSLock.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128408    
Attachments:
Description Flags
the patch.
ggaren: review-
reduced patch with only the JSLock fix. ggaren: review+

Mark Lam
Reported 2014-02-07 15:17:21 PST
This is the real fix for https://bugs.webkit.org/show_bug.cgi?id=128347 and will undo the workaround committed there.
Attachments
the patch. (19.10 KB, patch)
2014-02-07 15:31 PST, Mark Lam 		ggaren: review-
DetailsFormatted DiffDiff
reduced patch with only the JSLock fix. (3.36 KB, patch)
2014-02-07 16:11 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-02-07 15:31:10 PST
Created attachment 223505 [details] the patch.
Geoffrey Garen
Comment 2 2014-02-07 15:47:36 PST
Comment on attachment 223505 [details] the patch. Let's turn this into three patches: (1) A three-line patch that removes the problematic assignment of nullptr even if not dropping the lock, and removes the problematic testing of "m_vm->stackPointerAtVMEntry == entryStackPointer". (2) A mechanical patch that re-enables stack checking. (3) The re-architectural you've proposed here, which removes the iOS-specific code path. For (3), I think we need a little research into why that path currently exists, and is iOS-specific. I believe it was needed to fix some nasty bugs -- so we shouldn't just remove it without knowledge of why it's there.
Mark Lam
Comment 3 2014-02-07 16:11:42 PST
Created attachment 223509 [details] reduced patch with only the JSLock fix.
Geoffrey Garen
Comment 4 2014-02-07 16:15:07 PST
Comment on attachment 223509 [details] reduced patch with only the JSLock fix. r=me
Mark Lam
Comment 5 2014-02-07 16:19:57 PST
Thanks. Landed in r163661: <http://trac.webkit.org/r163661>.
Michael Saboff
Comment 6 2014-02-07 17:29:04 PST
Comment on attachment 223509 [details] reduced patch with only the JSLock fix. This patch should have deleted entryStackPointer since it is no longer needed.
Mark Lam
Comment 7 2014-02-07 17:30:48 PST
(In reply to comment #6) > (From update of attachment 223509 [details]) > This patch should have deleted entryStackPointer since it is no longer needed. Took care of that in https://webkit.org/b/128413, fixed in <http://trac.webkit.org/r163665>.
Mark Lam
Comment 8 2014-02-07 18:04:00 PST
ref: <rdar://problem/16008492>
Note You need to log in before you can comment on or make changes to this bug.