| Summary: | Fix bug in stack limit adjustments in JSLock. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 128408 | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2014-02-07 15:17:21 PST
Created attachment 223505 [details]
the patch.
Comment on attachment 223505 [details]
the patch.
Let's turn this into three patches:
(1) A three-line patch that removes the problematic assignment of nullptr even if not dropping the lock, and removes the problematic testing of "m_vm->stackPointerAtVMEntry == entryStackPointer".
(2) A mechanical patch that re-enables stack checking.
(3) The re-architectural you've proposed here, which removes the iOS-specific code path.
For (3), I think we need a little research into why that path currently exists, and is iOS-specific. I believe it was needed to fix some nasty bugs -- so we shouldn't just remove it without knowledge of why it's there.
Created attachment 223509 [details]
reduced patch with only the JSLock fix.
Comment on attachment 223509 [details]
reduced patch with only the JSLock fix.
r=me
Thanks. Landed in r163661: <http://trac.webkit.org/r163661>. Comment on attachment 223509 [details]
reduced patch with only the JSLock fix.
This patch should have deleted entryStackPointer since it is no longer needed.
(In reply to comment #6) > (From update of attachment 223509 [details]) > This patch should have deleted entryStackPointer since it is no longer needed. Took care of that in https://webkit.org/b/128413, fixed in <http://trac.webkit.org/r163665>. ref: <rdar://problem/16008492> |