Bug 128390

Summary: WebGL doesn't update with remotely hosted layers
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Dean Jackson 2014-02-07 13:11:18 PST 
WebGL doesn't push frames when attached to a remote layer host.
Comment 1 Dean Jackson 2014-02-07 13:12:24 PST 
<rdar://problem/15260182>
Comment 2 Dean Jackson 2014-02-07 13:19:37 PST 
Created attachment 223489 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-02-07 13:33:28 PST 
Comment on attachment 223489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223489&action=review

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:51
> +    bool m_providesContents;

You forgot to initialize this in the ctor.

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:62
> +    m_providesContents = [customLayer isKindOfClass:[WebGLLayer class]];

I think you could do this with the classname without pulling in WebGLLayer.h
Comment 4 Dean Jackson 2014-02-07 13:37:20 PST 
Comment on attachment 223489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223489&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:51
>> +    bool m_providesContents;
> 
> You forgot to initialize this in the ctor.

It's initalised in the ctor body.

>> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:62
>> +    m_providesContents = [customLayer isKindOfClass:[WebGLLayer class]];
> 
> I think you could do this with the classname without pulling in WebGLLayer.h

Yeah, I'm now trying to get there via GraphicsLayer
Comment 5 Dean Jackson 2014-02-07 14:07:57 PST 
Committed r163646: <http://trac.webkit.org/changeset/163646>