Bug 128389

Summary: [GTK] Make process model names properly meaningful
Product: WebKit Reporter: Adrian Perez <aperez>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, berto, cgarcia, commit-queue, gns, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Adrian Perez 2014-02-07 12:39:58 PST
[GTK] Make process model names properly meaningful
Comment 1 Adrian Perez 2014-02-07 13:30:45 PST
Created attachment 223492 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-07 13:31:22 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2014-02-07 13:39:51 PST
Comment on attachment 223492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223492&action=review

Looks good to me. Needs one more GTK+ reviewer to be committed.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:935
> +    if (newProcessModel != context->priv->context->processModel()) {
> +        context->priv->context->setUsesNetworkProcess(newProcessModel == ProcessModelMultipleSecondaryProcesses);
> +        context->priv->context->setProcessModel(newProcessModel);

Nit: This should probably be an early return.
Comment 4 Adrian Perez 2014-02-07 14:03:50 PST
Created attachment 223496 [details]
Patch
Comment 5 Adrian Perez 2014-02-07 14:05:20 PST
(In reply to comment #3)
> (From update of attachment 223492 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223492&
>
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:935
> > +    if (newProcessModel != context->priv->context->processModel()) {
> > +        context->priv->context->setUsesNetworkProcess(newProcessModel == ProcessModelMultipleSecondaryProcesses);
> > +        context->priv->context->setProcessModel(newProcessModel);
> 
> Nit: This should probably be an early return.

Updated patch, now there is an early return there :-)
Comment 6 WebKit Commit Bot 2014-02-08 00:20:27 PST
Comment on attachment 223496 [details]
Patch

Clearing flags on attachment: 223496

Committed r163698: <http://trac.webkit.org/changeset/163698>
Comment 7 WebKit Commit Bot 2014-02-08 00:20:30 PST
All reviewed patches have been landed.  Closing bug.