Bug 128354

Summary: [WK2] Fitler touch events only based on touch start
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Benjamin Poulain
Reported 2014-02-06 18:14:31 PST
[WK2] Fitler touch events only based on touch start
Attachments
Patch (5.21 KB, patch)
2014-02-06 18:17 PST, Benjamin Poulain 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-02-06 18:17:14 PST
Created attachment 223413 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-02-06 22:58:46 PST
Comment on attachment 223413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1380 > +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event) Odd that the name says "events" but the argument is "event". Maybe this should be shouldStartTrackingTouchEvents? The function can be |const|
Benjamin Poulain
Comment 3 2014-02-06 23:39:12 PST
(In reply to comment #2) > (From update of attachment 223413 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:1380 > > +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event) > > Odd that the name says "events" but the argument is "event". > > Maybe this should be shouldStartTrackingTouchEvents? That is a good point, I like shouldStartTrackingTouchEvents(). I will also rename the argument from "event" to touchStartEvent.
Benjamin Poulain
Comment 4 2014-02-07 13:57:09 PST
Committed r163645: <http://trac.webkit.org/changeset/163645>
Note You need to log in before you can comment on or make changes to this bug.