| Summary: | [WK2] Fitler touch events only based on touch start | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-02-06 18:14:31 PST
Created attachment 223413 [details]
Patch
Comment on attachment 223413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1380 > +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event) Odd that the name says "events" but the argument is "event". Maybe this should be shouldStartTrackingTouchEvents? The function can be |const| (In reply to comment #2) > (From update of attachment 223413 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:1380 > > +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event) > > Odd that the name says "events" but the argument is "event". > > Maybe this should be shouldStartTrackingTouchEvents? That is a good point, I like shouldStartTrackingTouchEvents(). I will also rename the argument from "event" to touchStartEvent. Committed r163645: <http://trac.webkit.org/changeset/163645> |