| Summary: | [iOS] make should build WebKit2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, dbates, ddkilzer, dfarler, joepeck | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Joseph Pecoraro
2014-02-06 17:50:05 PST
Created attachment 223412 [details]
[PATCH] Proposed Fix
Comment on attachment 223412 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=223412&action=review > Source/Makefile:-7 > -ifneq (,$(findstring iphoneos,$(SDKROOT))) > - MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit > -else ifneq (,$(findstring iphonesimulator,$(SDKROOT))) > - MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit > -endif Do we build WebInspectorUI for iOS? If not, then we need to exclude it from the iOS device and simulator builds. Comment on attachment 223412 [details]
[PATCH] Proposed Fix
Good call! I'll keep these lines and just add WebKit2 to the. Thanks for the review!
|