Bug 128351

Summary: [iOS] make should build WebKit2
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, dbates, ddkilzer, dfarler, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix dbates: review+, dbates: commit-queue-

Joseph Pecoraro
Reported 2014-02-06 17:50:05 PST
This is almost exactly a year old make file change. excluding WebKit2 on iOS. We should include it, build-webkit includes it.
Attachments
[PATCH] Proposed Fix (1.00 KB, patch)
2014-02-06 17:51 PST, Joseph Pecoraro 		dbates: review+
dbates: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-02-06 17:51:00 PST
Created attachment 223412 [details] [PATCH] Proposed Fix
Daniel Bates
Comment 2 2014-02-06 19:55:17 PST
Comment on attachment 223412 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=223412&action=review > Source/Makefile:-7 > -ifneq (,$(findstring iphoneos,$(SDKROOT))) > - MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit > -else ifneq (,$(findstring iphonesimulator,$(SDKROOT))) > - MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit > -endif Do we build WebInspectorUI for iOS? If not, then we need to exclude it from the iOS device and simulator builds.
Joseph Pecoraro
Comment 3 2014-02-06 19:58:57 PST
Comment on attachment 223412 [details] [PATCH] Proposed Fix Good call! I'll keep these lines and just add WebKit2 to the. Thanks for the review!
Joseph Pecoraro
Comment 4 2014-02-06 20:06:50 PST
<http://trac.webkit.org/changeset/163608>
Note You need to log in before you can comment on or make changes to this bug.