Bug 128347

Summary: Workaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSException when installing AppleInternal.mpkg
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2014-02-06 17:23:48 PST
The issue is that stack checks are failing when running on a different thread than the thread that created the VM. Disabling stack checking when we call JavaScript by creating a VM via JSGlobalContextCreate() and JSContextGroupCreate(). <rdar://problem/15979363>
Attachments
Patch (4.51 KB, patch)
2014-02-06 17:32 PST, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2014-02-06 17:32:23 PST
Created attachment 223409 [details] Patch
Geoffrey Garen
Comment 2 2014-02-06 17:35:05 PST
Comment on attachment 223409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223409&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + Added a flag to VM class called m_ignoreStackLimit that disables stack limit checks. > + We set this flag in JSContextGroupCreate() and JSGlobalContextCreateInGroup(). > + > + Disabled stack overflow tests in testapi.js since it uses these paths. You should explain that this is a temporary work-around, which we will remove once we have a proper fix. Otherwise, someone who's not you or me will think that we've removed stack checking from JavaScriptCore, and they will be reasonably alarmed.
Michael Saboff
Comment 3 2014-02-06 17:58:37 PST
Committed r163595: <http://trac.webkit.org/changeset/163595>
Note You need to log in before you can comment on or make changes to this bug.