Summary: | Web Inspector: show probe sets for script content views in the details sidebar | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 128332 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
BJ Burg
2014-02-06 14:31:32 PST
Created attachment 223545 [details]
patch - maybe needs new asset instead of PDF glyph
Comment on attachment 223545 [details] patch - maybe needs new asset instead of PDF glyph View in context: https://bugs.webkit.org/attachment.cgi?id=223545&action=review > Source/WebInspectorUI/UserInterface/DataGrid.js:385 > + insertColumn: function(columnIdentifier, columnData, insertionIndex) { Some newlines in this function would help readability. > Source/WebInspectorUI/UserInterface/DataGrid.js:399 > + console.log("columns ", this.orderedColumns.slice()); Debug statement. > Source/WebInspectorUI/UserInterface/ProbeSetDataGridNode.js:101 > + default: console.log("Don't know how to represent sample:", sample); console.error? (In reply to comment #3) > (From update of attachment 223545 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223545&action=review > > > Source/WebInspectorUI/UserInterface/DataGrid.js:385 > > + insertColumn: function(columnIdentifier, columnData, insertionIndex) { > > Some newlines in this function would help readability. I added a few, but the code is already put into 5-line chunks for setting up each DOM element or whatever. Not sure how much more can be split into separate actions. Committed r163735: <http://trac.webkit.org/changeset/163735> |