Bug 128332

Summary: Web Inspector: Clean up DataGrid and add table columns incrementally
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 128333    
Attachments:
Description Flags
patch none

Blaze Burg
Reported 2014-02-06 14:28:28 PST
This is implemented in ProbeSetDataGrid subclass, but maybe better in the base class.
Attachments
patch (44.43 KB, patch)
2014-02-06 19:20 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-06 14:29:15 PST
<rdar://problem/16005948>
Blaze Burg
Comment 2 2014-02-06 19:06:37 PST
I had some column addition code but wasn't too sure whether it did the right thing or not. I ended up refactoring DataGrid so that it's much more obvious that adding columns incrementally is correct. See changelog on patch for details.
Blaze Burg
Comment 3 2014-02-06 19:20:07 PST
Created attachment 223415 [details] patch
Timothy Hatcher
Comment 4 2014-02-07 11:09:48 PST
Comment on attachment 223415 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=223415&action=review > Source/WebInspectorUI/UserInterface/DataGrid.js:336 > + for (var [identifier, column] of this.columns) Sweet!
WebKit Commit Bot
Comment 5 2014-02-07 11:44:47 PST
Comment on attachment 223415 [details] patch Clearing flags on attachment: 223415 Committed r163637: <http://trac.webkit.org/changeset/163637>
WebKit Commit Bot
Comment 6 2014-02-07 11:44:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.