Bug 128332

Summary:

Web Inspector: Clean up DataGrid and add table columns incrementally

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

128333

Attachments:

Description	Flags
patch	none

Description BJ Burg 2014-02-06 14:28:28 PST

This is implemented in ProbeSetDataGrid subclass, but maybe better in the base class.

Comment 1 Radar WebKit Bug Importer 2014-02-06 14:29:15 PST

<rdar://problem/16005948>

Comment 2 BJ Burg 2014-02-06 19:06:37 PST

I had some column addition code but wasn't too sure whether it did the right thing or not. I ended up refactoring DataGrid so that it's much more obvious that adding columns incrementally is correct. See changelog on patch for details.

Comment 3 BJ Burg 2014-02-06 19:20:07 PST

Created attachment 223415 [details]
patch

Comment 4 Timothy Hatcher 2014-02-07 11:09:48 PST

Comment on attachment 223415 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223415&action=review

> Source/WebInspectorUI/UserInterface/DataGrid.js:336
> +        for (var [identifier, column] of this.columns)

Sweet!

Comment 5 WebKit Commit Bot 2014-02-07 11:44:47 PST

Comment on attachment 223415 [details]
patch

Clearing flags on attachment: 223415

Committed r163637: <http://trac.webkit.org/changeset/163637>

Comment 6 WebKit Commit Bot 2014-02-07 11:44:49 PST

All reviewed patches have been landed.  Closing bug.