Bug 128325

Summary:

MathMLTextElement::childShouldCreateRenderer should return false for the mspace element

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cfleizach, commit-queue, dbarton, mrobinson, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

124838

Attachments:

Description	Flags
Patch V1	none
Patch V1	none
Patch V2	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Patch V3	cfleizach: review+
Patch (final version)	none

Frédéric Wang (:fredw)

Reported 2014-02-06 12:27:25 PST

I'm extracting this small change from bug 124838. The mspace element can not have children, so MathMLTextElement::childShouldCreateRenderer should always return false. Currently it renders true for text node. That should not be a problem since RenderMathMLSpace::isChildAllowed returns false, but let's explicitly prevent children on the content side. I'll also add a regression test to ensure that mspace does not have child renderers.

Attachments
Patch V1 (2.67 KB, patch) 2014-02-06 12:44 PST, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch V1 (2.67 KB, patch) 2014-02-06 12:46 PST, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch V2 (8.56 KB, patch) 2014-02-07 01:53 PST, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (496.95 KB, application/zip) 2014-02-07 03:11 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (458.79 KB, application/zip) 2014-02-07 03:42 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (520.43 KB, application/zip) 2014-02-07 05:09 PST, Build Bot	no flags	Details
Patch V3 (9.54 KB, patch) 2014-02-07 06:34 PST, Frédéric Wang (:fredw)	cfleizach: review+	Details Formatted Diff Diff
Patch (final version) (9.54 KB, patch) 2014-02-07 09:38 PST, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2014-02-06 12:44:14 PST

Created attachment 223370 [details] Patch V1 First try without test reference to get the PNG output.

Frédéric Wang (:fredw)

Comment 2 2014-02-06 12:46:39 PST

Created attachment 223371 [details] Patch V1

Frédéric Wang (:fredw)

Comment 3 2014-02-07 01:53:48 PST

Created attachment 223434 [details] Patch V2 Trying with the GTK screenshot...

Build Bot

Comment 4 2014-02-07 03:11:42 PST

Comment on attachment 223434 [details] Patch V2 Attachment 223434 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5999911136919552 New failing tests: mathml/presentation/mspace-children.html

Build Bot

Comment 5 2014-02-07 03:11:44 PST

Created attachment 223445 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-02-07 03:42:36 PST

Comment on attachment 223434 [details] Patch V2 Attachment 223434 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4960967137951744 New failing tests: mathml/presentation/mspace-children.html

Build Bot

Comment 7 2014-02-07 03:42:38 PST

Created attachment 223447 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 8 2014-02-07 05:09:47 PST

Comment on attachment 223434 [details] Patch V2 Attachment 223434 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6156317873930240 New failing tests: mathml/presentation/mspace-children.html

Build Bot

Comment 9 2014-02-07 05:09:50 PST

Created attachment 223449 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Frédéric Wang (:fredw)

Comment 10 2014-02-07 06:34:26 PST

Created attachment 223451 [details] Patch V3 Now trying with Mac's expected text output.

chris fleizach

Comment 11 2014-02-07 09:36:51 PST

Comment on attachment 223451 [details] Patch V3 View in context: https://bugs.webkit.org/attachment.cgi?id=223451&action=review > Source/WebCore/ChangeLog:9 > + childShouldCreateRenderer always returns false. always "return" false

Frédéric Wang (:fredw)

Comment 12 2014-02-07 09:38:55 PST

Created attachment 223461 [details] Patch (final version)

WebKit Commit Bot

Comment 13 2014-02-07 10:15:05 PST

Comment on attachment 223461 [details] Patch (final version) Clearing flags on attachment: 223461 Committed r163626: <http://trac.webkit.org/changeset/163626>

WebKit Commit Bot

Comment 14 2014-02-07 10:15:10 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.