Bug 128323

Summary: [Win] Correct IME Regression after r141479
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Critical CC: ap
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 107737    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Brent Fulgham
Reported 2014-02-06 12:09:34 PST
Some sloppy refactoring in http://trac.webkit.org/changeset/141479 broke IME under Windows.
Attachments
Patch (1.28 KB, patch)
2014-02-06 12:11 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.82 KB, patch)
2014-02-06 12:15 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.28 KB, patch)
2014-02-06 12:22 PST, Brent Fulgham 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-02-06 12:11:32 PST
Created attachment 223363 [details] Patch
Brent Fulgham
Comment 2 2014-02-06 12:15:43 PST
Created attachment 223365 [details] Patch
Brent Fulgham
Comment 3 2014-02-06 12:16:23 PST
Comment on attachment 223365 [details] Patch Remove extraneous cancelComposition, since the refactored Editor::cancelCompositionIfSelectionIsInvalid() already does this.
Tim Horton
Comment 4 2014-02-06 12:22:14 PST
Comment on attachment 223365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223365&action=review > Source/WebKit/win/WebView.cpp:-5556 > - if (targetFrame) > - targetFrame->editor().cancelComposition(); > - updateSelectionForIME is not the only caller of resetIME, please revert this part.
Brent Fulgham
Comment 5 2014-02-06 12:22:48 PST
Created attachment 223367 [details] Patch
Brent Fulgham
Comment 6 2014-02-06 12:33:56 PST
Committed r163557: <http://trac.webkit.org/changeset/163557>
Brent Fulgham
Comment 7 2014-02-06 12:44:35 PST
<rdar://problem/15952986>
Note You need to log in before you can comment on or make changes to this bug.