Bug 128323 - [Win] Correct IME Regression after r141479
Summary: [Win] Correct IME Regression after r141479
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Critical
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 107737
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-06 12:09 PST by Brent Fulgham
Modified: 2014-02-06 12:44 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2014-02-06 12:11 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.82 KB, patch)
2014-02-06 12:15 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.28 KB, patch)
2014-02-06 12:22 PST, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-02-06 12:09:34 PST 
Some sloppy refactoring in http://trac.webkit.org/changeset/141479 broke IME under Windows.
Comment 1 Brent Fulgham 2014-02-06 12:11:32 PST 
Created attachment 223363 [details]
Patch
Comment 2 Brent Fulgham 2014-02-06 12:15:43 PST 
Created attachment 223365 [details]
Patch
Comment 3 Brent Fulgham 2014-02-06 12:16:23 PST 
Comment on attachment 223365 [details]
Patch

Remove extraneous cancelComposition, since the refactored Editor::cancelCompositionIfSelectionIsInvalid() already does this.
Comment 4 Tim Horton 2014-02-06 12:22:14 PST 
Comment on attachment 223365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223365&action=review

> Source/WebKit/win/WebView.cpp:-5556
> -    if (targetFrame)
> -        targetFrame->editor().cancelComposition();
> -

updateSelectionForIME is not the only caller of resetIME, please revert this part.
Comment 5 Brent Fulgham 2014-02-06 12:22:48 PST 
Created attachment 223367 [details]
Patch
Comment 6 Brent Fulgham 2014-02-06 12:33:56 PST 
Committed r163557: <http://trac.webkit.org/changeset/163557>
Comment 7 Brent Fulgham 2014-02-06 12:44:35 PST 
<rdar://problem/15952986>