Summary: | [EFL][WK2] WebView should be able to configure to set fixed layout | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jinwoo Song <jinwoo7.song> | ||||||
Component: | WebKit EFL | Assignee: | Jinwoo Song <jinwoo7.song> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, ryuan.choi, seojuyung2, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jinwoo Song
2014-02-06 02:33:01 PST
Created attachment 223325 [details]
Patch
Looks good to me. Comment on attachment 223325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223325&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.h:912 > + * * Remove *. > Source/WebKit2/UIProcess/API/efl/ewk_view.h:918 > +EAPI Eina_Bool ewk_view_use_fixed_layout_set(Evas_Object *o, Eina_Bool enabled); Hmm, is *ewk_view_fixed_layout_set* enough ? > Source/WebKit2/UIProcess/API/efl/ewk_view.h:928 > +EAPI Eina_Bool ewk_view_use_fixed_layout_get(const Evas_Object *o); ditto. How about ewk_view_layout_fixed_get/get()? (In reply to comment #4) > How about ewk_view_layout_fixed_get/get()? If it is more close to efl function naming style, I agree to use it ! Created attachment 223426 [details]
Patch
Changed API name as suggested by Daniel and Gyuyoung.
Comment on attachment 223426 [details]
Patch
LGTM
Comment on attachment 223426 [details] Patch Clearing flags on attachment: 223426 Committed r163614: <http://trac.webkit.org/changeset/163614> All reviewed patches have been landed. Closing bug. |