Bug 128295

Summary: [WK2] Add the minimumLayoutSizeOverride SPI to WKWebView
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Benjamin Poulain 2014-02-05 20:58:17 PST
[WK2] Add the minimumLayoutSizeOverride SPI to WKWebView
Comment 1 Benjamin Poulain 2014-02-05 20:58:40 PST
Created attachment 223301 [details]
Patch
Comment 2 Anders Carlsson 2014-02-05 21:34:09 PST
Comment on attachment 223301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223301&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:26
> +#import "WKWebView.h"

This should be #import <WebKit2/WKWebView.h>.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:30
> +@interface WKWebView (Private)

The category name should be WKPrivate here.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:33
> +@property (nonatomic) CGSize minimumLayoutSizeOverride;

We've decided to use underscores for SPI methods. This should be something like:

@property (nonatomic setter=_setMinimumLayoutSizeOverride:) CGSize _minimumLayoutSizeOverride;

and the getters and setters should be named appropriately.
Comment 3 Benjamin Poulain 2014-02-05 22:14:27 PST
Committed r163514: <http://trac.webkit.org/changeset/163514>