| Summary: | [WK2] Add the minimumLayoutSizeOverride SPI to WKWebView | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-02-05 20:58:17 PST
Created attachment 223301 [details]
Patch
Comment on attachment 223301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223301&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:26 > +#import "WKWebView.h" This should be #import <WebKit2/WKWebView.h>. > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:30 > +@interface WKWebView (Private) The category name should be WKPrivate here. > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:33 > +@property (nonatomic) CGSize minimumLayoutSizeOverride; We've decided to use underscores for SPI methods. This should be something like: @property (nonatomic setter=_setMinimumLayoutSizeOverride:) CGSize _minimumLayoutSizeOverride; and the getters and setters should be named appropriately. Committed r163514: <http://trac.webkit.org/changeset/163514> |