RESOLVED FIXED 128295
[WK2] Add the minimumLayoutSizeOverride SPI to WKWebView 
https://bugs.webkit.org/show_bug.cgi?id=128295
Summary [WK2] Add the minimumLayoutSizeOverride SPI to WKWebView
Benjamin Poulain
Reported 2014-02-05 20:58:17 PST
[WK2] Add the minimumLayoutSizeOverride SPI to WKWebView
Attachments
Patch (6.95 KB, patch)
2014-02-05 20:58 PST, Benjamin Poulain 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-02-05 20:58:40 PST
Created attachment 223301 [details] Patch
Anders Carlsson
Comment 2 2014-02-05 21:34:09 PST
Comment on attachment 223301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223301&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:26 > +#import "WKWebView.h" This should be #import <WebKit2/WKWebView.h>. > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:30 > +@interface WKWebView (Private) The category name should be WKPrivate here. > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:33 > +@property (nonatomic) CGSize minimumLayoutSizeOverride; We've decided to use underscores for SPI methods. This should be something like: @property (nonatomic setter=_setMinimumLayoutSizeOverride:) CGSize _minimumLayoutSizeOverride; and the getters and setters should be named appropriately.
Benjamin Poulain
Comment 3 2014-02-05 22:14:27 PST
Committed r163514: <http://trac.webkit.org/changeset/163514>
Note You need to log in before you can comment on or make changes to this bug.