Bug 128293 – Transfer the non-fast-scrollable region to the UI process for iOS

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Transfer the non-fast-scrollable region to the UI process for iOS

[Simon Fraser (smfr)]

Created attachment 223297 [details]
Patch

[WebKit Commit Bot]

Attachment 223297 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTree.cpp:148:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Comment on attachment 223297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223297&action=review

That is great, thanks a lot for fixing this!

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:81
> +    virtual void frameViewNonFastScrollableRegionChanged(FrameView*);

Missing override here.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1387
>      if (m_needTouchEvents && !m_isPageSuspended) {

I think you can nuke m_needTouchEvents.

[Simon Fraser (smfr)]

https://trac.webkit.org/r163516

[Simon Fraser (smfr)]

https://trac.webkit.org/r163516

[Csaba Osztrogonác]

(In reply to comment #5)
> https://trac.webkit.org/r163516

It broke the !ENABLE(ASYNC_SCROLLING) builds, fix is in https://bugs.webkit.org/show_bug.cgi?id=128299