| Summary: | Transfer the non-fast-scrollable region to the UI process for iOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, benjamin, cmarcelo, commit-queue, jamesr, luiz, ossy, sam, simon.fraser, tonikitoo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 128299 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-02-05 20:28:44 PST
Created attachment 223297 [details]
Patch
Attachment 223297 [details] did not pass style-queue:
ERROR: Source/WebCore/page/scrolling/ScrollingTree.cpp:148: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 223297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223297&action=review That is great, thanks a lot for fixing this! > Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:81 > + virtual void frameViewNonFastScrollableRegionChanged(FrameView*); Missing override here. > Source/WebKit2/UIProcess/WebPageProxy.cpp:1387 > if (m_needTouchEvents && !m_isPageSuspended) { I think you can nuke m_needTouchEvents. (In reply to comment #5) > https://trac.webkit.org/r163516 It broke the !ENABLE(ASYNC_SCROLLING) builds, fix is in https://bugs.webkit.org/show_bug.cgi?id=128299 |