Bug 128293 - Transfer the non-fast-scrollable region to the UI process for iOS
Summary: Transfer the non-fast-scrollable region to the UI process for iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on: 128299
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-05 20:28 PST by Simon Fraser (smfr)
Modified: 2014-02-06 00:53 PST (History)
10 users (show)

See Also:

Attachments
Patch (19.05 KB, patch)
2014-02-05 20:36 PST, Simon Fraser (smfr) 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-02-05 20:28:44 PST 
Transfer the non-fast-scrollable region to the UI process for iOS
Comment 1 Simon Fraser (smfr) 2014-02-05 20:36:46 PST 
Created attachment 223297 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-05 20:37:58 PST 
Attachment 223297 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTree.cpp:148:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2014-02-05 20:45:43 PST 
Comment on attachment 223297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223297&action=review

That is great, thanks a lot for fixing this!

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:81
> +    virtual void frameViewNonFastScrollableRegionChanged(FrameView*);

Missing override here.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1387
>      if (m_needTouchEvents && !m_isPageSuspended) {

I think you can nuke m_needTouchEvents.
Comment 4 Simon Fraser (smfr) 2014-02-05 22:53:00 PST 
https://trac.webkit.org/r163516
Comment 5 Simon Fraser (smfr) 2014-02-05 22:53:00 PST 
https://trac.webkit.org/r163516
Comment 6 Csaba Osztrogonác 2014-02-06 00:53:02 PST 
(In reply to comment #5)
> https://trac.webkit.org/r163516

It broke the !ENABLE(ASYNC_SCROLLING) builds, fix is in https://bugs.webkit.org/show_bug.cgi?id=128299