RESOLVED FIXED 128293
Transfer the non-fast-scrollable region to the UI process for iOS 
https://bugs.webkit.org/show_bug.cgi?id=128293
Summary Transfer the non-fast-scrollable region to the UI process for iOS
Simon Fraser (smfr)
Reported 2014-02-05 20:28:44 PST
Transfer the non-fast-scrollable region to the UI process for iOS
Attachments
Patch (19.05 KB, patch)
2014-02-05 20:36 PST, Simon Fraser (smfr) 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-02-05 20:36:46 PST
Created attachment 223297 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-05 20:37:58 PST
Attachment 223297 [details] did not pass style-queue: ERROR: Source/WebCore/page/scrolling/ScrollingTree.cpp:148: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2014-02-05 20:45:43 PST
Comment on attachment 223297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223297&action=review That is great, thanks a lot for fixing this! > Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:81 > + virtual void frameViewNonFastScrollableRegionChanged(FrameView*); Missing override here. > Source/WebKit2/UIProcess/WebPageProxy.cpp:1387 > if (m_needTouchEvents && !m_isPageSuspended) { I think you can nuke m_needTouchEvents.
Simon Fraser (smfr)
Comment 4 2014-02-05 22:53:00 PST
https://trac.webkit.org/r163516
Simon Fraser (smfr)
Comment 5 2014-02-05 22:53:00 PST
https://trac.webkit.org/r163516
Csaba Osztrogonác
Comment 6 2014-02-06 00:53:02 PST
(In reply to comment #5) > https://trac.webkit.org/r163516 It broke the !ENABLE(ASYNC_SCROLLING) builds, fix is in https://bugs.webkit.org/show_bug.cgi?id=128299
Note You need to log in before you can comment on or make changes to this bug.