Bug 128286

Summary:

run-webkit-tests should have a --no-timeout option

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, glenn, matthew_hanson, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Adding --no-timeout option	none

Description Joseph Pecoraro 2014-02-05 17:17:41 PST

It is very difficult to debug a test in DumpRenderTree if there is a timeout. Also, --time-out-ms doesn't seem to be respected.

Comment 1 Alexey Proskuryakov 2014-02-06 09:36:33 PST

FWIW, --time-out-ms always works for me. It gets tricker with WebKit2, because there is an additional option to pass to disable a different timeout, I don't remember which one offhand.

Comment 2 Berta József 2014-03-31 03:20:34 PDT

Created attachment 228164 [details]
Adding --no-timeout option

Comment 3 Joseph Pecoraro 2014-03-31 10:45:53 PDT

Comment on attachment 228164 [details]
Adding --no-timeout option

r=me, nice!

Comment 4 WebKit Commit Bot 2014-03-31 11:15:54 PDT

Comment on attachment 228164 [details]
Adding --no-timeout option

Clearing flags on attachment: 228164

Committed r166515: <http://trac.webkit.org/changeset/166515>

Comment 5 WebKit Commit Bot 2014-03-31 11:15:58 PDT

All reviewed patches have been landed.  Closing bug.