Bug 128284

Summary: Support encoding and decoding of Regions
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Simon Fraser (smfr) 2014-02-05 16:54:33 PST
Support encoding and decoding of Regions
Comment 1 Simon Fraser (smfr) 2014-02-05 16:57:08 PST
Created attachment 223281 [details]
Patch
Comment 2 Anders Carlsson 2014-02-05 17:58:45 PST
Comment on attachment 223281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223281&action=review

> Source/WebCore/platform/graphics/Region.cpp:336
> +    for (Shape::SpanIterator span = spans_begin(), end = spans_end(); span != end && span + 1 != end; ++span) {

auto span

> Source/WebCore/platform/graphics/Region.cpp:343
> +        for (Shape::SegmentIterator segment = segments_begin(span), end = segments_end(span); segment != end && segment + 1 != end; segment += 2) {

auto segment

> Source/WebCore/platform/graphics/Region.h:75
> +        { }

Should be newline:
{
}

> Source/WebCore/platform/graphics/Region.h:79
> +        { }

Newline
{
}
Comment 3 Simon Fraser (smfr) 2014-02-05 20:27:22 PST
https://trac.webkit.org/r163509