Bug 128280 – Add sourceFrame to WKNavigationAction

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Add sourceFrame to WKNavigationAction

[Anders Carlsson]

Created attachment 223279 [details]
Patch

[WebKit Commit Bot]

Attachment 223279 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:32:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h:34:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 223279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223279&action=review

> Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:137
> +static RetainPtr<WKFrameInfo> frameInfoFromWebFrameProxy(WebFrameProxy& webFrameProxy)
> +{
> +    auto frameInfo = adoptNS([[WKFrameInfo alloc] init]);
> +
> +    [frameInfo setMainFrame:webFrameProxy.isMainFrame()];
> +
> +    return frameInfo;
> +}

I would have made this an internal WKFrameInfo method (either an initializer or a class method) so that we don’t have to repeat it if we end up vending WKFrameInfo instances from other files.

[Anders Carlsson]

Committed r163501: <http://trac.webkit.org/changeset/163501>