Summary: | Add sourceFrame to WKNavigationAction | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, mitz | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2014-02-05 16:43:06 PST
Created attachment 223279 [details]
Patch
Attachment 223279 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:32: Missing spaces around = [whitespace/operators] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h:34: Missing spaces around = [whitespace/operators] [4]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 223279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223279&action=review > Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:137 > +static RetainPtr<WKFrameInfo> frameInfoFromWebFrameProxy(WebFrameProxy& webFrameProxy) > +{ > + auto frameInfo = adoptNS([[WKFrameInfo alloc] init]); > + > + [frameInfo setMainFrame:webFrameProxy.isMainFrame()]; > + > + return frameInfo; > +} I would have made this an internal WKFrameInfo method (either an initializer or a class method) so that we don’t have to repeat it if we end up vending WKFrameInfo instances from other files. Committed r163501: <http://trac.webkit.org/changeset/163501> |