RESOLVED FIXED128280
Add sourceFrame to WKNavigationAction 
https://bugs.webkit.org/show_bug.cgi?id=128280
Summary Add sourceFrame to WKNavigationAction
Anders Carlsson
Reported 2014-02-05 16:43:06 PST
Add sourceFrame to WKNavigationAction
Attachments
Patch (18.21 KB, patch)
2014-02-05 16:43 PST, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-02-05 16:43:46 PST
Created attachment 223279 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-05 16:45:31 PST
Attachment 223279 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:32: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h:34: Missing spaces around = [whitespace/operators] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2014-02-05 16:48:04 PST
Comment on attachment 223279 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223279&action=review > Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:137 > +static RetainPtr<WKFrameInfo> frameInfoFromWebFrameProxy(WebFrameProxy& webFrameProxy) > +{ > + auto frameInfo = adoptNS([[WKFrameInfo alloc] init]); > + > + [frameInfo setMainFrame:webFrameProxy.isMainFrame()]; > + > + return frameInfo; > +} I would have made this an internal WKFrameInfo method (either an initializer or a class method) so that we don’t have to repeat it if we end up vending WKFrameInfo instances from other files.
Anders Carlsson
Comment 4 2014-02-05 17:44:12 PST
Committed r163501: <http://trac.webkit.org/changeset/163501>
Note You need to log in before you can comment on or make changes to this bug.