Bug 128257

Summary: IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, jonlee, jsbell, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 124521    
Attachments:
Description Flags
Patch v1 sam: review+

Description Brady Eidson 2014-02-05 10:26:42 PST 
IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails

- The schema of the index record table is out of whack
- We mess up storing auto generated keys in indexes
- After the above are fixed, something is preventing us from returning that auto generated id in the result of an index.get()
Comment 1 Brady Eidson 2014-02-05 15:14:03 PST 
(In reply to comment #0)
> IDB: storage/indexeddb/mozilla/autoincrement-indexes.html fails
> ...
> - After the above are fixed, something is preventing us from returning that auto generated id in the result of an index.get()

This was because the IDBGetResult shipped back from the database process did not contain the object store key path when it was needed.
Comment 2 Radar WebKit Bug Importer 2014-02-05 15:21:56 PST 
<rdar://problem/15995237>
Comment 3 Brady Eidson 2014-02-05 15:24:16 PST 
Created attachment 223271 [details]
Patch v1
Comment 4 WebKit Commit Bot 2014-02-05 15:26:23 PST 
Attachment 223271 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:77:  The parameter name "result" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:74:  The parameter name "result" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2014-02-05 15:55:35 PST 
http://trac.webkit.org/changeset/163482