Bug 128249

Summary: Add support for MallocScribble to FastMalloc
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web Template FrameworkAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dbates, ggaren, jeffrey+webkit, oliver, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=164431
Attachments:
Description Flags
Patch v1 oliver: review-

Description David Kilzer (:ddkilzer) 2014-02-05 07:48:43 PST 
We should add support for MallocScribble to FastMalloc.
Comment 1 David Kilzer (:ddkilzer) 2014-02-05 07:49:00 PST 
<rdar://problem/15946481>
Comment 2 David Kilzer (:ddkilzer) 2014-02-05 11:37:30 PST 
Created attachment 223252 [details]
Patch v1
Comment 3 WebKit Commit Bot 2014-02-05 11:40:05 PST 
Attachment 223252 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/FastMalloc.cpp:460:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WTF/wtf/FastMalloc.cpp:1273:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Oliver Hunt 2014-02-05 11:48:29 PST 
Comment on attachment 223252 [details]
Patch v1

It would be better to just modify POISON_DEALLOCATION as that will get all deallocations, and already has the correct allocation size
Comment 5 David Kilzer (:ddkilzer) 2016-11-04 13:58:34 PDT 
FastMalloc was replaced by bmalloc.