Bug 128247

Summary: ElementRuleCollector should not use StyleResolver::State
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, buildbot, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+
rebased patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 none

Description Antti Koivisto 2014-02-05 06:35:13 PST
improve factoring
Comment 1 Antti Koivisto 2014-02-05 12:05:40 PST
Created attachment 223254 [details]
patch
Comment 2 Antti Koivisto 2014-02-05 12:34:55 PST
Created attachment 223257 [details]
rebased patch
Comment 3 Build Bot 2014-02-05 13:33:02 PST
Comment on attachment 223257 [details]
rebased patch

Attachment 223257 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4774333763289088

New failing tests:
fast/parser/xhtml-alternate-entities.xml
Comment 4 Build Bot 2014-02-05 13:33:04 PST
Created attachment 223260 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-02-05 13:34:55 PST
Comment on attachment 223257 [details]
rebased patch

Attachment 223257 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6401327370338304

New failing tests:
fast/parser/xhtml-alternate-entities.xml
Comment 6 Build Bot 2014-02-05 13:34:58 PST
Created attachment 223262 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Antti Koivisto 2014-02-05 13:46:26 PST
https://trac.webkit.org/r163475