Bug 128247 - ElementRuleCollector should not use StyleResolver::State
Summary: ElementRuleCollector should not use StyleResolver::State
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 06:35 PST by Antti Koivisto
Modified: 2014-02-05 13:46 PST (History)
9 users (show)

See Also:

Attachments
patch (21.49 KB, patch)
2014-02-05 12:05 PST, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
rebased patch (21.37 KB, patch)
2014-02-05 12:34 PST, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (592.02 KB, application/zip)
2014-02-05 13:33 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (501.89 KB, application/zip)
2014-02-05 13:34 PST, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-02-05 06:35:13 PST 
improve factoring
Comment 1 Antti Koivisto 2014-02-05 12:05:40 PST 
Created attachment 223254 [details]
patch
Comment 2 Antti Koivisto 2014-02-05 12:34:55 PST 
Created attachment 223257 [details]
rebased patch
Comment 3 Build Bot 2014-02-05 13:33:02 PST 
Comment on attachment 223257 [details]
rebased patch

Attachment 223257 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4774333763289088

New failing tests:
fast/parser/xhtml-alternate-entities.xml
Comment 4 Build Bot 2014-02-05 13:33:04 PST 
Created attachment 223260 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-02-05 13:34:55 PST 
Comment on attachment 223257 [details]
rebased patch

Attachment 223257 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6401327370338304

New failing tests:
fast/parser/xhtml-alternate-entities.xml
Comment 6 Build Bot 2014-02-05 13:34:58 PST 
Created attachment 223262 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Antti Koivisto 2014-02-05 13:46:26 PST 
https://trac.webkit.org/r163475