Bug 128236

Summary: Copying failing test paths from build.webkit.org/dashboard popovers also copies non-selectable links
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80159    
Bug Blocks:    
Attachments:
Description Flags
proposed fix none

Description Alexey Proskuryakov 2014-02-05 00:27:02 PST 
Copying multiple paths from test results popover also copies diff/pretty diff/images/stderr/history links text, even though it's non-selectable.

This is a manifestation of bug 80159. It's quite annoying, so I'd like to work around it.

----------------
css2.1/20110323/border-conflict-element-001d.htmimagesimage diffhistory
css2.1/20110323/c541-word-sp-001.htmimagesimage diffhistory
css2.1/20110323/floats-001.htmlimagesimage diffhistory
css2.1/20110323/margin-collapse-clear-012.htmimagesimage diffhistory
css2.1/20110323/margin-collapse-clear-013.htmimagesimage diffhistory
----------------
Comment 1 Alexey Proskuryakov 2014-02-05 00:38:14 PST 
Created attachment 223215 [details]
proposed fix
Comment 2 Timothy Hatcher 2014-02-05 11:11:02 PST 
Comment on attachment 223215 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=223215&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:221
> +            var iterator = document.createNodeIterator(

Fancy!
Comment 3 WebKit Commit Bot 2014-02-05 11:59:49 PST 
Comment on attachment 223215 [details]
proposed fix

Clearing flags on attachment: 223215

Committed r163464: <http://trac.webkit.org/changeset/163464>
Comment 4 WebKit Commit Bot 2014-02-05 11:59:51 PST 
All reviewed patches have been landed.  Closing bug.