Bug 12823

Summary: REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event
Product: WebKit Reporter: Tom Brown <tom>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, KwhiteRight, mitz
Priority: P1 Keywords: HasReduction, Regression
Version: 420+   
Hardware: All   
OS: OS X 10.4   
Attachments:
Description Flags
Test case reduction
none
Go through shouldSelect() in the selection-via-autoscroll case too
none
Go through shouldSelect() in the selection-via-autoscroll case too darin: review+

Description Tom Brown 2007-02-19 18:11:47 PST
When inside an event handler for the "selectstart" event, the selection should be preventable, either by returning false, or by calling the Event.preventDefault method. This was working in earlier nightlies. I have narrowed it down to some change between r16968 (working) and r16977 (broken).
Comment 1 Tom Brown 2007-02-19 18:13:11 PST
Created attachment 13260 [details]
Test case reduction

Open the file, follow the instructions.
Comment 3 mitz 2007-02-23 03:37:02 PST
Created attachment 13345 [details]
Go through shouldSelect() in the selection-via-autoscroll case too

Includes change log and layout test.
Comment 4 mitz 2007-02-23 03:38:49 PST
Comment on attachment 13345 [details]
Go through shouldSelect() in the selection-via-autoscroll case too

Woops, what are the pixel results doing there?!
Comment 5 mitz 2007-02-23 03:42:19 PST
Created attachment 13346 [details]
Go through shouldSelect() in the selection-via-autoscroll case too
Comment 6 Darin Adler 2007-02-23 08:36:30 PST
Comment on attachment 13346 [details]
Go through shouldSelect() in the selection-via-autoscroll case too

r=me
Comment 7 Sam Weinig 2007-02-23 18:47:06 PST
Landed in r19835.