Bug 12823

Summary: REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event
Product: WebKit Reporter: Tom Brown <tom>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, KwhiteRight, mitz
Priority: P1 Keywords: HasReduction, Regression
Version: 420+   
Hardware: All   
OS: OS X 10.4   
Attachments:
Description Flags
Test case reduction
none
Go through shouldSelect() in the selection-via-autoscroll case too
none
Go through shouldSelect() in the selection-via-autoscroll case too darin: review+

Tom Brown
Reported 2007-02-19 18:11:47 PST
When inside an event handler for the "selectstart" event, the selection should be preventable, either by returning false, or by calling the Event.preventDefault method. This was working in earlier nightlies. I have narrowed it down to some change between r16968 (working) and r16977 (broken).
Attachments
Test case reduction (474 bytes, text/html)
2007-02-19 18:13 PST, Tom Brown 		no flags
Details
Go through shouldSelect() in the selection-via-autoscroll case too (32.91 KB, patch)
2007-02-23 03:37 PST, mitz 		no flags
DetailsFormatted DiffDiff
Go through shouldSelect() in the selection-via-autoscroll case too (5.05 KB, patch)
2007-02-23 03:42 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tom Brown
Comment 1 2007-02-19 18:13:11 PST
Created attachment 13260 [details] Test case reduction Open the file, follow the instructions.
mitz
Comment 3 2007-02-23 03:37:02 PST
Created attachment 13345 [details] Go through shouldSelect() in the selection-via-autoscroll case too Includes change log and layout test.
mitz
Comment 4 2007-02-23 03:38:49 PST
Comment on attachment 13345 [details] Go through shouldSelect() in the selection-via-autoscroll case too Woops, what are the pixel results doing there?!
mitz
Comment 5 2007-02-23 03:42:19 PST
Created attachment 13346 [details] Go through shouldSelect() in the selection-via-autoscroll case too
Darin Adler
Comment 6 2007-02-23 08:36:30 PST
Comment on attachment 13346 [details] Go through shouldSelect() in the selection-via-autoscroll case too r=me
Sam Weinig
Comment 7 2007-02-23 18:47:06 PST
Landed in r19835.
Note You need to log in before you can comment on or make changes to this bug.