Bug 12823 - REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event
Summary: REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectst...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 420+
Hardware: All OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: HasReduction, Regression
Depends on:
Blocks:
 
Reported: 2007-02-19 18:11 PST by Tom Brown
Modified: 2007-02-23 18:47 PST (History)
3 users (show)

See Also:


Attachments
Test case reduction (474 bytes, text/html)
2007-02-19 18:13 PST, Tom Brown
no flags Details
Go through shouldSelect() in the selection-via-autoscroll case too (32.91 KB, patch)
2007-02-23 03:37 PST, mitz
no flags Details | Formatted Diff | Diff
Go through shouldSelect() in the selection-via-autoscroll case too (5.05 KB, patch)
2007-02-23 03:42 PST, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Brown 2007-02-19 18:11:47 PST
When inside an event handler for the "selectstart" event, the selection should be preventable, either by returning false, or by calling the Event.preventDefault method. This was working in earlier nightlies. I have narrowed it down to some change between r16968 (working) and r16977 (broken).
Comment 1 Tom Brown 2007-02-19 18:13:11 PST
Created attachment 13260 [details]
Test case reduction

Open the file, follow the instructions.
Comment 3 mitz 2007-02-23 03:37:02 PST
Created attachment 13345 [details]
Go through shouldSelect() in the selection-via-autoscroll case too

Includes change log and layout test.
Comment 4 mitz 2007-02-23 03:38:49 PST
Comment on attachment 13345 [details]
Go through shouldSelect() in the selection-via-autoscroll case too

Woops, what are the pixel results doing there?!
Comment 5 mitz 2007-02-23 03:42:19 PST
Created attachment 13346 [details]
Go through shouldSelect() in the selection-via-autoscroll case too
Comment 6 Darin Adler 2007-02-23 08:36:30 PST
Comment on attachment 13346 [details]
Go through shouldSelect() in the selection-via-autoscroll case too

r=me
Comment 7 Sam Weinig 2007-02-23 18:47:06 PST
Landed in r19835.