Bug 128223

Summary:

Declare GlyphBuffers on the heap instead of the stack

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

NEW ---

Severity:

Normal

CC:

commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, schenney, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review-

Description Myles C. Maxfield 2014-02-04 16:48:30 PST

Declare GlyphBuffers on the heap instead of the stack

Comment 1 Myles C. Maxfield 2014-02-04 16:51:49 PST

<rdar://problem/15675294>

Comment 2 Myles C. Maxfield 2014-02-04 17:12:45 PST

Created attachment 223183 [details]
Patch

Comment 3 Simon Fraser (smfr) 2014-02-05 11:54:09 PST

Comment on attachment 223183 [details]
Patch

It's not clear to me that this the correct solution.
Why is GlyphBuffer so big? Can its inline capacities be reduced?
Does this patch slow us down? Should we cache a GlyphBuffer?