Bug 128223

Summary: Declare GlyphBuffers on the heap instead of the stack
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: NEW    
Severity: Normal CC: commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, schenney, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review-

Myles C. Maxfield
Reported 2014-02-04 16:48:30 PST
Declare GlyphBuffers on the heap instead of the stack
Attachments
Patch (17.15 KB, patch)
2014-02-04 17:12 PST, Myles C. Maxfield 		simon.fraser: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-02-04 16:51:49 PST
<rdar://problem/15675294>
Myles C. Maxfield
Comment 2 2014-02-04 17:12:45 PST
Created attachment 223183 [details] Patch
Simon Fraser (smfr)
Comment 3 2014-02-05 11:54:09 PST
Comment on attachment 223183 [details] Patch It's not clear to me that this the correct solution. Why is GlyphBuffer so big? Can its inline capacities be reduced? Does this patch slow us down? Should we cache a GlyphBuffer?
Note You need to log in before you can comment on or make changes to this bug.