Handling of opaque roots is wrong in EdenCollections

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Hahnenberg]

The set of opaque roots is always cleared during each collection. We should instead persist the set of opaque roots across EdenCollections and only clear it at the beginning of FullCollections.

[BJ Burg]

Created attachment 223184 [details]
patch

[WebKit Commit Bot]

Attachment 223184 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h:67:  The parameter name "button" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:95:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:101:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:141:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:538:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:687:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:823:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:833:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:841:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:865:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:886:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:973:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h:80:  The parameter name "button" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 13 in 61 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Hahnenberg]

(In reply to comment #1)
> Created an attachment (id=223184) [details]
> patch

I think this is the wrong bug :-)

[BJ Burg]

Comment on attachment 223184 [details]
patch

Wrong bugzilla bug. :|

[Mark Hahnenberg]

Created attachment 223285 [details]
Patch

[Mark Hahnenberg]

Created attachment 223286 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 223286 [details]
Patch

Clearing flags on attachment: 223286

Committed r163507: <http://trac.webkit.org/changeset/163507>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Mark Hahnenberg]

D'oh! I forgot to check in the tests.

[Mark Hahnenberg]

Created attachment 223486 [details]
Patch

[Geoffrey Garen]

Comment on attachment 223486 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 223486 [details]
Patch

Clearing flags on attachment: 223486

Committed r163806: <http://trac.webkit.org/changeset/163806>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.