Bug 128210

Summary:

Handling of opaque roots is wrong in EdenCollections

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, glenn

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
Patch	none
Patch	none
Patch	none

Mark Hahnenberg

Reported 2014-02-04 14:53:02 PST

The set of opaque roots is always cleared during each collection. We should instead persist the set of opaque roots across EdenCollections and only clear it at the beginning of FullCollections.

Attachments
patch (187.68 KB, text/plain) 2014-02-04 17:16 PST, Blaze Burg	no flags	Details
Patch (13.24 KB, patch) 2014-02-05 18:08 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (13.24 KB, patch) 2014-02-05 18:17 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (2.66 KB, patch) 2014-02-07 12:58 PST, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2014-02-04 17:16:36 PST

Created attachment 223184 [details] patch

WebKit Commit Bot

Comment 2 2014-02-04 17:18:16 PST

Attachment 223184 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h:67: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:95: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:101: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:141: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:538: whitespace before ']' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:687: whitespace before ']' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:823: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:833: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:841: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:865: whitespace before ']' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:886: whitespace before ']' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:973: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h:80: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 13 in 61 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Hahnenberg

Comment 3 2014-02-04 17:18:51 PST

(In reply to comment #1) > Created an attachment (id=223184) [details] > patch I think this is the wrong bug :-)

Blaze Burg

Comment 4 2014-02-04 17:21:12 PST

Comment on attachment 223184 [details] patch Wrong bugzilla bug. :|

Mark Hahnenberg

Comment 5 2014-02-05 18:08:11 PST

Created attachment 223285 [details] Patch

Mark Hahnenberg

Comment 6 2014-02-05 18:17:24 PST

Created attachment 223286 [details] Patch