Bug 128201

Summary:

webKitCookieStorageCopyRequestHeaderFieldsForURL builds an empty Cookie header when there are no cookies

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Page Loading

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2014-02-04 11:50:12 PST

On platforms that use our webKitCookieStorageCopyRequestHeaderFieldsForURL shim, we fail two regression tests:

http/tests/navigation/ping-same-origin.html
http/tests/navigation/ping-cross-origin.html

This is because we send an empty Cookie header. We shouldn't send one when there are no cookies.

Comment 1 Alexey Proskuryakov 2014-02-04 11:52:20 PST

Created attachment 223150 [details]
proposed fix

Comment 2 Sam Weinig 2014-02-04 14:27:38 PST

Comment on attachment 223150 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=223150&action=review

> Source/WebKit2/Shared/mac/CookieStorageShim.mm:64
> +    if (cookies.isNull())

I think we usually do if (!cookies)

Comment 3 WebKit Commit Bot 2014-02-04 15:29:06 PST

Comment on attachment 223150 [details]
proposed fix

Clearing flags on attachment: 223150

Committed r163409: <http://trac.webkit.org/changeset/163409>

Comment 4 WebKit Commit Bot 2014-02-04 15:29:08 PST

All reviewed patches have been landed.  Closing bug.