| Summary: | REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||
| Component: | Layout and Rendering | Assignee: | Antti Koivisto <koivisto> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | justin.garcia, koivisto | ||||||
| Priority: | P1 | Keywords: | LayoutTestFailure, Regression | ||||||
| Version: | 420+ | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.4 | ||||||||
| URL: | http://build.webkit.org/results/post-commit-pixel-powerpc-mac-os-x/3675/editing/pasteboard/4641033-diffs.html | ||||||||
| Attachments: |
|
||||||||
|
Description
mitz
2007-02-19 16:30:08 PST
Created attachment 13273 [details]
another attempt to figure out who should paint the caret
Caret should generally be painted by the containing block of the caret node. Only exception is when the caret node is itself a block and the caret is inside it (not after it). This happens with empty editable block elements.
Comment on attachment 13273 [details]
another attempt to figure out who should paint the caret
r=me
Created attachment 13284 [details]
yet another
- added method to SelectionController for testing if caret is inside or outside the node based on Justin's comments
- added test case for <div editable><select> case too
Comment on attachment 13273 [details]
another attempt to figure out who should paint the caret
Clearing the review, there is a new patch.
Comment on attachment 13284 [details]
yet another
r=me
|