Summary: | WK: Cannot select text inside clickable containers. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Enrica Casucci
2014-02-04 11:16:04 PST
Created attachment 223145 [details]
Patch
Comment on attachment 223145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223145&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:846 > + info.url = linkElement->document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkElement->getAttribute(HTMLNames::hrefAttr))); > + } else if (element->isLink()) { > info.url = element->document().completeURL(stripLeadingAndTrailingHTMLSpaces(element->getAttribute(HTMLNames::hrefAttr))); > + elementIsLinkOrImage = true; Would be slightly nice to factor this so you only call completeURL() once. > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:852 > + } > + if (!elementIsLinkOrImage) { I would prefer a blank line between these two. Thanks for the review. I've followed your suggestion and factored out CompleteURL. Committed revision 163400. |