Bug 128186

Summary: GC timer should always do a FullCollection
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch msaboff: review+

Mark Hahnenberg
Reported 2014-02-04 08:41:03 PST
Right now the GC timer does whatever type of collection the next collection would have been, which is almost always an EdenCollection. It then thinks that it has done all of the work it was supposed to do and never schedules another GC. Ideally we'd like to have some heuristics for the timer that would schedule both EdenCollections and FullCollections, but the easiest fix for now is to always do FullCollections, since that will at least be a non-regression.
Attachments
Patch (2.12 KB, patch)
2014-02-04 09:26 PST, Mark Hahnenberg 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-02-04 09:26:16 PST
Created attachment 223125 [details] Patch
Mark Hahnenberg
Comment 2 2014-02-04 09:51:27 PST
Committed r163384: <http://trac.webkit.org/changeset/163384>
Geoffrey Garen
Comment 3 2014-02-04 10:34:48 PST
> Ideally we'd like to have some heuristics for the timer that would schedule both EdenCollections and FullCollections Yeah -- and the schedule for full collections should be very long, to avoid touching too many pages.
Note You need to log in before you can comment on or make changes to this bug.