Bug 128170

Summary: [GTK] Add $(feature_defines) when generating InjectedBundle code from IDLs
Product: WebKit Reporter: Carlos Garnacho <carlosg>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98931    
Attachments:
Description Flags
patch, adds $(feature_defines) none

Description Carlos Garnacho 2014-02-04 02:42:33 PST 
Patch in bug #98931 relies on the ENABLE_TOUCH_EVENTS define being available at the time of generating the code from the EventSenderProxy IDL, but the --defines switch is empty, so those functions are invariably opted out. I'm attaching a patch that adds $(feature_defines) so config defines are available when generating the code.
Comment 1 Carlos Garnacho 2014-02-04 02:50:47 PST 
Created attachment 223090 [details]
patch, adds $(feature_defines)
Comment 2 Carlos Garcia Campos 2014-02-04 06:17:03 PST 
Comment on attachment 223090 [details]
patch, adds $(feature_defines)

Good catch! thanks
Comment 3 Carlos Garcia Campos 2014-02-04 06:21:59 PST 
Comment on attachment 223090 [details]
patch, adds $(feature_defines)

hope it's not too late this might be causing issues when generating the api docs
Comment 4 Carlos Garcia Campos 2014-02-04 06:22:26 PST 
See http://webkit-queues.appspot.com/results/4927924343930880
Comment 5 Carlos Garcia Campos 2014-02-04 06:24:06 PST 
(In reply to comment #4)
> See http://webkit-queues.appspot.com/results/4927924343930880

hmm, wait, this is probably the other patch that depends on this one
Comment 6 Carlos Garcia Campos 2014-02-04 06:25:51 PST 
This one seems to be failing as well 

https://webkit-queues.appspot.com/results/5611648777715712
Comment 7 Carlos Garcia Campos 2014-02-04 06:42:44 PST 
Comment on attachment 223090 [details]
patch, adds $(feature_defines)

I think EWS mixed both patches or something, let's try to land this, it shouldn't affect the GObject DOM bindings
Comment 8 WebKit Commit Bot 2014-02-04 06:45:46 PST 
Comment on attachment 223090 [details]
patch, adds $(feature_defines)

Clearing flags on attachment: 223090

Committed r163375: <http://trac.webkit.org/changeset/163375>
Comment 9 WebKit Commit Bot 2014-02-04 06:45:48 PST 
All reviewed patches have been landed.  Closing bug.