| Summary: | [GTK] [Stable] Build unittests only when requested | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pacho Ramos <pachoramos1> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | berto, bugs-noreply, cgarcia, gnome, gustavo, zan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Hey, thanks for the patch. The problem is that we're switching to cmake soon so this will be obsolete in a few weeks. We run the tests all the time and changing the workflow of the developers (even if it's such a small change) shortly before the switch is probably not a good idea. This would also need changes in the build-webkit script else the build bots will probably break. We are not going to switch to cmake in the stable branches. Maybe would be interesting to apply it to 2.2.x branch only then (if there will be more releases) I wouldn't change that at this point for the reasons I already said, but I don't have strong arguments against fixing it in the stable branches either. Not opposed, but this is only useful for the 2.2.x stable branch right? In 2.4 we have developer mode. |
Created attachment 223074 [details] webkit-gtk-2.2.4-unittests-build.patch We are applying this patch on Gentoo to build unittests only when going to run tests Thanks for applying it