Bug 128162

Summary: DFG PutByVal on typed arrays should detect OutOfBounds sooner
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 128039    
Attachments:
Description Flags
the patch
mhahnenberg: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
none
the patch
none
pathc for landing none

Filip Pizlo
Reported 2014-02-03 22:57:18 PST
We are seeing super slow convergence on dispatchDraw in gbemu.
Attachments
the patch (15.96 KB, patch)
2014-02-04 13:39 PST, Filip Pizlo 		mhahnenberg: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (1.25 MB, application/zip)
2014-02-04 14:43 PST, Build Bot 		no flags
Details
the patch (22.16 KB, patch)
2014-02-04 15:05 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
pathc for landing (22.32 KB, patch)
2014-02-04 15:42 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-04 13:39:18 PST
Created attachment 223156 [details] the patch
Mark Hahnenberg
Comment 2 2014-02-04 13:49:22 PST
Comment on attachment 223156 [details] the patch r=me
Build Bot
Comment 3 2014-02-04 14:43:00 PST
Comment on attachment 223156 [details] the patch Attachment 223156 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5429457875632128 New failing tests: js/dfg-convert-this-dom-window.html
Build Bot
Comment 4 2014-02-04 14:43:01 PST
Created attachment 223161 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Filip Pizlo
Comment 5 2014-02-04 15:05:33 PST
Created attachment 223162 [details] the patch
Filip Pizlo
Comment 6 2014-02-04 15:42:57 PST
Created attachment 223175 [details] pathc for landing
Filip Pizlo
Comment 7 2014-02-04 16:58:59 PST
Landed in http://trac.webkit.org/changeset/163418
Mark Hahnenberg
Comment 8 2014-02-04 17:31:01 PST
Build fix landed in http://trac.webkit.org/changeset/163420.
Note You need to log in before you can comment on or make changes to this bug.