Bug 128162

Summary: DFG PutByVal on typed arrays should detect OutOfBounds sooner
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 128039    
Attachments:
Description Flags
the patch
mhahnenberg: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
none
the patch
none
pathc for landing none

Description Filip Pizlo 2014-02-03 22:57:18 PST 
We are seeing super slow convergence on dispatchDraw in gbemu.
Comment 1 Filip Pizlo 2014-02-04 13:39:18 PST 
Created attachment 223156 [details]
the patch
Comment 2 Mark Hahnenberg 2014-02-04 13:49:22 PST 
Comment on attachment 223156 [details]
the patch

r=me
Comment 3 Build Bot 2014-02-04 14:43:00 PST 
Comment on attachment 223156 [details]
the patch

Attachment 223156 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5429457875632128

New failing tests:
js/dfg-convert-this-dom-window.html
Comment 4 Build Bot 2014-02-04 14:43:01 PST 
Created attachment 223161 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Filip Pizlo 2014-02-04 15:05:33 PST 
Created attachment 223162 [details]
the patch
Comment 6 Filip Pizlo 2014-02-04 15:42:57 PST 
Created attachment 223175 [details]
pathc for landing
Comment 7 Filip Pizlo 2014-02-04 16:58:59 PST 
Landed in http://trac.webkit.org/changeset/163418
Comment 8 Mark Hahnenberg 2014-02-04 17:31:01 PST 
Build fix landed in http://trac.webkit.org/changeset/163420.