Bug 128162 - DFG PutByVal on typed arrays should detect OutOfBounds sooner
Summary: DFG PutByVal on typed arrays should detect OutOfBounds sooner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 128039
  Show dependency tree / graph
 
Reported: 2014-02-03 22:57 PST by Filip Pizlo
Modified: 2014-02-04 17:31 PST (History)
11 users (show)

See Also:

Attachments
the patch (15.96 KB, patch)
2014-02-04 13:39 PST, Filip Pizlo 		mhahnenberg: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (1.25 MB, application/zip)
2014-02-04 14:43 PST, Build Bot 		no flags Details
the patch (22.16 KB, patch)
2014-02-04 15:05 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
pathc for landing (22.32 KB, patch)
2014-02-04 15:42 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-03 22:57:18 PST 
We are seeing super slow convergence on dispatchDraw in gbemu.
Comment 1 Filip Pizlo 2014-02-04 13:39:18 PST 
Created attachment 223156 [details]
the patch
Comment 2 Mark Hahnenberg 2014-02-04 13:49:22 PST 
Comment on attachment 223156 [details]
the patch

r=me
Comment 3 Build Bot 2014-02-04 14:43:00 PST 
Comment on attachment 223156 [details]
the patch

Attachment 223156 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5429457875632128

New failing tests:
js/dfg-convert-this-dom-window.html
Comment 4 Build Bot 2014-02-04 14:43:01 PST 
Created attachment 223161 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Filip Pizlo 2014-02-04 15:05:33 PST 
Created attachment 223162 [details]
the patch
Comment 6 Filip Pizlo 2014-02-04 15:42:57 PST 
Created attachment 223175 [details]
pathc for landing
Comment 7 Filip Pizlo 2014-02-04 16:58:59 PST 
Landed in http://trac.webkit.org/changeset/163418
Comment 8 Mark Hahnenberg 2014-02-04 17:31:01 PST 
Build fix landed in http://trac.webkit.org/changeset/163420.